Skip to content

Encode to png for Framebuffer. #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Encode to png for Framebuffer. #718

wants to merge 2 commits into from

Conversation

jonpsy
Copy link
Contributor

@jonpsy jonpsy commented Nov 30, 2021

@lu-wang-g As discussed. Related #679

@google-cla google-cla bot added the cla: yes label Nov 30, 2021
lu-wang-g
lu-wang-g reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@lu-wang-g lu-wang-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor comment.

tensorflow_lite_support/examples/task/vision/desktop/utils/image_utils.cc Outdated
Comment on lines 98 to 99
channels = 1;
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: return 1;

@jonpsy jonpsy mentioned this pull request Dec 3, 2021
Closed
7 tasks
@lu-wang-g
Copy link
Member

This PR has a conflict with master. Need to resolve it before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-wang-g lu-wang-g lu-wang-g approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonpsy @lu-wang-g